codeant-ai-for-open-source[bot] commented on code in PR #40967:
URL: https://github.com/apache/superset/pull/40967#discussion_r3624102442
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts:
##########
@@ -19,55 +19,12 @@
import { ControlPanelsContainerProps } from
'@superset-ui/chart-controls/types';
import { GenericDataType } from '@apache-superset/core/common';
import controlPanel from
'../../../src/Timeseries/Regular/Scatter/controlPanel';
+import { getControl, mockControls } from '../helpers';
Review Comment:
**Suggestion:** `mockControls` is imported but never used in this test file,
which introduces dead code and may fail CI where unused imports are lint
errors. Remove the unused import to keep the test clean and lint-safe.
[possible bug]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Test file contains dead, unused import code.
- ⚠️ Potential lint failures depending on CI lint settings.
- ⚠️ Slightly increases maintenance noise in test suite.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open
`superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts`
and inspect imports at lines `19-22`, where `{ getControl, mockControls }`
is imported
from `../helpers`.
2. Search within the same file (`controlPanel.test.ts:1-163`) for usages of
`mockControls`; only `getControl` is referenced for control lookups, while
`mockControls`
is never used.
3. Because `mockControls` is unused, TypeScript tooling and common ESLint
configurations
(e.g., `no-unused-vars` / `no-unused-imports`) will report this as an unused
import when
running the test or lint tasks on this file.
4. In CI environments where such lint warnings are treated as errors, this
unused import
can cause the lint step to fail, even though the tests themselves are
otherwise correct.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=885b6c441ba049e7ba97ff39c7b8ccf3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=885b6c441ba049e7ba97ff39c7b8ccf3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Scatter/controlPanel.test.ts
**Line:** 22:22
**Comment:**
*Possible Bug: `mockControls` is imported but never used in this test
file, which introduces dead code and may fail CI where unused imports are lint
errors. Remove the unused import to keep the test clean and lint-safe.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40967&comment_hash=530049f654fae564543fea1b300a134f2786efb17d4852afd7842d084a9112d0&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40967&comment_hash=530049f654fae564543fea1b300a134f2786efb17d4852afd7842d084a9112d0&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
