bito-code-review[bot] commented on PR #42300:
URL: https://github.com/apache/superset/pull/42300#issuecomment-5042717817
<!-- Bito Reply -->
The flagged issue is correct. The code comment states that clamping occurs
"When explicit Y axis bounds are set," but the implementation triggers clamping
whenever `yAxisMin` or `yAxisMax` are defined, which includes cases where they
are derived automatically from the data. To resolve this, the comment should be
updated to reflect that clamping occurs whenever Y axis bounds are defined,
regardless of whether they were explicitly set by the user or derived
automatically.
**superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts**
```
// When Y axis bounds are defined, clamp series values to those bounds
// instead of leaving raw out-of-range values in place. ECharts axis
// clipping can otherwise drop an out-of-bounds point (and the line
// segments around it) entirely rather than truncating it at the
// boundary (see https://github.com/apache/superset/issues/27449).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
