graceguo-supercat commented on a change in pull request #8404: [WIP][feature]Dashboard filter scope selector modal URL: https://github.com/apache/incubator-superset/pull/8404#discussion_r339835094
########## File path: superset/assets/src/dashboard/components/filterscope/FilterScopeTree.jsx ########## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import PropTypes from 'prop-types'; +import CheckboxTree from 'react-checkbox-tree'; +import 'react-checkbox-tree/lib/react-checkbox-tree.css'; + +import CheckboxChecked from '../../../components/CheckboxChecked'; +import CheckboxUnchecked from '../../../components/CheckboxUnchecked'; +import CheckboxHalfchecked from '../../../components/CheckboxHalfchecked'; +import renderFilterScopeTreeNodes from './renderFilterScopeTreeNodes'; + +const propTypes = { + nodes: PropTypes.arrayOf(PropTypes.object).isRequired, + checked: PropTypes.arrayOf(PropTypes.string).isRequired, + expanded: PropTypes.arrayOf(PropTypes.string).isRequired, + onCheck: PropTypes.func.isRequired, + onExpand: PropTypes.func.isRequired, +}; + +export default function FilterScopeTree({ + nodes, + checked, + expanded, + onCheck, + onExpand, +}) { + return ( + <CheckboxTree + showExpandAll + expandOnClick + showNodeIcon={false} + nodes={renderFilterScopeTreeNodes(nodes)} + checked={checked} + expanded={expanded} + onCheck={onCheck} + onExpand={onExpand} + onClick={() => {}} Review comment: > same with `icons` what does this mean? icons used in this file are outside of the render function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
