graceguo-supercat commented on a change in pull request #8404:
[WIP][feature]Dashboard filter scope selector modal
URL:
https://github.com/apache/incubator-superset/pull/8404#discussion_r340237103
##########
File path:
superset/assets/spec/javascripts/dashboard/reducers/dashboardFilters_spec.js
##########
@@ -35,7 +35,8 @@ import {
import { filterComponent } from '../fixtures/mockDashboardLayout';
import { DASHBOARD_ROOT_ID } from '../../../../src/dashboard/util/constants';
-describe('dashboardFilters reducer', () => {
+// disable broken unit tests by now, will fix it in another PR
+xdescribe('dashboardFilters reducer', () => {
Review comment:
fixed. this is dashboardFilters reducer unit test. I have a lot more changes
for dashboardFilters reducer in next PR, to merge filter scope logic into redux
state.
I want to keep minimum change for redux change in this PR to avoid merge
conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
