rusackas opened a new pull request, #42328: URL: https://github.com/apache/superset/pull/42328
### SUMMARY Two additions in support of the legacy viz pipeline removal (#41714): **1. Example charts for every migrated legacy visualization that had none.** The Misc Charts example dashboard gains eight charts: Sales Calendar Heatmap (`cal_heatmap`), Population Nightingale Rose (`rose`), Population Partition (`partition`), Population Paired t-Test (`paired_ttest`), Total Sales Bullet (`bullet`), Sales Period Pivot (`time_pivot`), Population Percent Change (`echarts_timeseries_line` with the restored percent-change mode from the `compare` migration), and Region Population Time Table (`time_table`). They use the existing `wb_health_population` and `cleaned_sales_data` example datasets — no new data files. The other migrated types (country map, parallel coordinates, chord, horizon, world map) already have examples on other dashboards. **2. A Playwright thumbnail-capture tool** (`npm run playwright:thumbnails`, gated behind `CAPTURE_THUMBNAILS=1` so CI suites skip it). It renders each of these example charts standalone at 512×512 and overwrites the plugin's viz-picker gallery `thumbnail.png` — refreshing the stale bullet/rose/etc. artwork from live charts. The percent-change capture lands as a new `Line3.png` gallery image for the Line chart, to be registered in the plugin metadata once captured. Dark-theme thumbnail variants are out of scope for the first pass. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Misc Charts dashboard grows from 3 to 11 charts (screenshots to follow from the ephemeral env). ### TESTING INSTRUCTIONS 1. `superset load-examples` on this branch, open the Misc Charts dashboard and confirm the eight new charts render. 2. Run `npm run playwright:thumbnails` against the running instance and confirm the plugin thumbnails are refreshed. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
