bito-code-review[bot] commented on PR #42328:
URL: https://github.com/apache/superset/pull/42328#issuecomment-5061377861
<!-- Bito Reply -->
The flagged issue is correct. The current `RENDERED_CHART_SELECTOR` is
indeed too restrictive because it forces the presence of `svg`, `canvas`, or
`table` elements, which causes failures for charts rendered as plain HTML (like
`ag-grid-table`).
To resolve this, you should update the selector to focus on the visibility
of the chart container itself, ensuring it is not in a loading state. You can
modify the constant in
`superset-frontend/playwright/tests/tools/capture-viz-thumbnails.spec.ts` as
follows:
```typescript
const RENDERED_CHART_SELECTOR =
'[data-test="chart-container"]:not(:has([data-test="loading-indicator"]))';
```
This change removes the dependency on specific child tags while maintaining
the check that the loading indicator is absent. I have checked the PR comments,
and there are no other actionable suggestions to address at this time.
**superset-frontend/playwright/tests/tools/capture-viz-thumbnails.spec.ts**
```
const RENDERED_CHART_SELECTOR =
'[data-test="chart-container"]:not(:has([data-test="loading-indicator"]))';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
