villebro commented on code in PR #40084:
URL: https://github.com/apache/superset/pull/40084#discussion_r3648313759
##########
docker/docker-bootstrap.sh:
##########
@@ -98,7 +98,9 @@ case "${1}" in
echo " 🔒 Werkzeug debugger disabled (set SUPERSET_DEBUG_ENABLED=true
to enable)"
fi
- flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0
--exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*"
+ flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0 \
+ --extra-files "/app/superset/extensions/.reload_trigger" \
Review Comment:
Interesting, I thought I already tried this once, and it didn't work
correctly. Maybe I did something wrong. I think there's already some logic that
pokes at some `__init__.py` file in dev mode to basically achieve the same
thing, can you make sure we're not duplicating that logic?
One more thing: do we need to add `superset/extensions/.reload_trigger` to
`.gitignore`?
##########
superset/extensions/api.py:
##########
@@ -169,7 +169,7 @@ def get(self, publisher: str, name: str, **kwargs: Any) ->
Response:
@protect()
@safe
- @expose("/<publisher>/<name>/<file>", methods=("GET",))
+ @expose("/<publisher>/<name>/<path:file>", methods=("GET",))
Review Comment:
Oh nice improvement - until now I haven't bumped into subdirectories for FE
chunks, but I suppose they may become relevant at some point. Can we double
check that our CLI tooling can handle subdirectories in the built MF assets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
