rusackas commented on code in PR #40084:
URL: https://github.com/apache/superset/pull/40084#discussion_r3648362335
##########
docker/docker-bootstrap.sh:
##########
@@ -98,7 +98,9 @@ case "${1}" in
echo " 🔒 Werkzeug debugger disabled (set SUPERSET_DEBUG_ENABLED=true
to enable)"
fi
- flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0
--exclude-patterns
"*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*"
+ flask run -p $PORT --reload $DEBUGGER_FLAG --host=0.0.0.0 \
+ --extra-files "/app/superset/extensions/.reload_trigger" \
Review Comment:
Good call on both. The `__init__.py` poking you're remembering is this same
watcher on `master` (it `utime`s `superset/__init__.py` to wake Flask), and
this PR removes that path, so the sentinel is the only trigger left. The CLI
never touches Superset files, it only rebuilds into the extension's `dist`.
I suspect the earlier attempt misbehaved because the trigger lived on an
import path, and VirtioFS fires events on reads... the sentinel is never
imported, and the bootstrap excludes `__init__.py` so the old path can't sneak
back in.
Added `superset/extensions/.reload_trigger` to `.gitignore` in b3b4b9ee7a.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
