bito-code-review[bot] commented on PR #42430: URL: https://github.com/apache/superset/pull/42430#issuecomment-5082023738
<!-- Bito Reply --> The change in `scripts/check_license.sh` correctly updates the exit code from `-1` to `255` in two locations within the `acquire_rat_jar` function. This aligns with ShellCheck SC2242, which recommends using exit codes in the range 0-255, as negative exit codes are not portable and are often interpreted as 255 in many shells. **scripts/check_license.sh** ``` - exit -1 + exit 255 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
