hainenber commented on code in PR #42430:
URL: https://github.com/apache/superset/pull/42430#discussion_r3651752405
##########
docker/tag_latest_release.sh:
##########
@@ -163,10 +163,10 @@ do
# Iterate through the components of the version strings
for (( j=0; j<${#THIS_TAG_NAME_ARRAY[@]}; j++ )); do
echo "Comparing ${THIS_TAG_NAME_ARRAY[$j]} to
${LATEST_RELEASE_TAG_ARRAY[$j]}"
- if [[ $((THIS_TAG_NAME_ARRAY[$j])) > $((LATEST_RELEASE_TAG_ARRAY[$j]))
]]; then
+ if [[ $((THIS_TAG_NAME_ARRAY[$j])) -gt
$((LATEST_RELEASE_TAG_ARRAY[$j])) ]]; then
Review Comment:
Resolves https://www.shellcheck.net/wiki/SC2071. Since we're comparing
numeric string in the extracted semver, using `-lt/-gt` is more correct
semantically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
