rusackas opened a new pull request, #42439:
URL: https://github.com/apache/superset/pull/42439

   ### SUMMARY
   Tehran and Alborz provinces in `iran.geojson` were both mapped to `IR-07`, 
and Razavi Khorasan was mapped to `IR-30` (Alborz's real code), leaving `IR-09` 
unused entirely. That made it impossible to color Tehran and Alborz 
independently in the country map viz, and any data keyed on `IR-09` (Razavi 
Khorasan) or `IR-30` (Alborz) would land on the wrong province. This matches 
what came up in #31991: Alborz now gets `IR-30` and Razavi Khorasan gets 
`IR-09`, per [ISO 3166-2:IR](https://en.wikipedia.org/wiki/ISO_3166-2:IR). 
Tehran keeps `IR-07`.
   
   Added a unit test that pins this down going forward by asserting every 
province in the geojson has a unique ISO code and that the three provinces in 
question map correctly.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A, this only touches the underlying geojson data, not rendering code.
   
   ### TESTING INSTRUCTIONS
   `npm run test -- 
plugins/legacy-plugin-chart-country-map/test/countries/iran.test.ts`
   
   Or build a country map chart with country set to Iran and confirm Tehran and 
Alborz can be colored independently.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #31991
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Fixes #31991


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to