greggailly commented on code in PR #42483:
URL: https://github.com/apache/superset/pull/42483#discussion_r3659389961
##########
superset-frontend/src/explore/components/ExploreContainer/ExploreDndContext.tsx:
##########
@@ -362,7 +411,22 @@ export const ExploreDndContextProvider:
FC<ExploreDndContextProps> = ({
DatasourcePanel drags (which carry a value) get a preview.
*/}
<DragOverlay dropAnimation={null}>
- {activeData?.value ? (
+ {activeData?.type === DndItemType.Folder ? (
+ <DragOverlayContainer align="center" justify="space-between">
+ <Flex align="center" gap={4}>
+ <Icons.FolderOutlined iconSize="l" />
+ <span>{activeData.name}</span>
+ </Flex>
+ <FolderDragBadge>
+ {tn(
+ '%s column',
+ '%s columns',
+ activeData.items?.length ?? 0,
+ activeData.items?.length ?? 0,
+ )}
Review Comment:
Count is correct, but label is not generic, pushing a fix to rename this
"fields"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
