rusackas commented on PR #42483: URL: https://github.com/apache/superset/pull/42483#issuecomment-5127251498
@greggailly nice feature, and the regression tests for the single-value folder-drop bug are a good touch. Codeant's thread on `DndMetricSelect.tsx` is still open though: `createAdhocMetricFromColumn` leaves `aggregate` unset for columns outside Numeric/String/Boolean/Temporal, so a folder drop can create an incomplete metric. Mind landing a fix before this merges? Let me know if you need any help with these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
