mikebridge commented on PR #42534: URL: https://github.com/apache/superset/pull/42534#issuecomment-5104854661
Carried over and resolved the outstanding review feedback from #41509 in `3240cab91d`: - **codeant: orphaned active tab** → the fallback effect already landed in Beto's later commits; this push strengthens the regression test to assert Results is the *active* tab (`aria-selected`) and the active tabpanel is non-empty, per the follow-up comment — the label-only assertion could pass on a blank panel. - **codeant: type annotations** → `ds_class: type[Datasource] | None` (imported aliased — the legacy view class in that module is itself named `Datasource`), annotated the MagicMock locals, replaced the identity-lambda patch with a typed named helper. - **@rebenitez1802: package-lock churn** → already gone from the diff (dropped in Beto's "Address comments" commits). - **@mikebridge: symmetric server-side drill gate** → already present on the branch (`query_actions.py` refuses `supports_drill_to_detail=False` mirroring the samples gate, with unit coverage); the empty template sections are filled in this PR's description. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
