rusackas commented on PR #42534: URL: https://github.com/apache/superset/pull/42534#issuecomment-5127242004
@mikebridge couple of things Copilot flagged that are still open. The `supports_samples` gate in `views.py`'s `samples()` runs before the guest-user branch, so it short-circuits ahead of the dashboard/access checks instead of after them. Feels like it should live below those. Also the `<pre>` to `Alert` swap in `SamplesPane`/`useResultsPane` drops whitespace preservation, so multi-line errors and stack traces get harder to read. Worth wrapping the description in something that keeps `white-space: pre-wrap`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
