rusackas commented on PR #38695: URL: https://github.com/apache/superset/pull/38695#issuecomment-5107818758
Checking back in, @sancho11. `MixedTimeseries/types.ts` and `Timeseries/types.ts` still type `labelPosition` with values (`insideTop`, `insideBottom`, `insideLeft`, `insideRight`) that the control's choices list never exposes, might be worth reusing the existing position enum in `src/types.ts` instead of hand-rolling a new one. Also still waiting to hear from @yousoph or @kasiazjc on whether this is the direction we want, since @sadpandajoe flagged we may have shipped something like this before and rolled it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
