rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5107840290
Thanks @durgaprasadml, the pagination fix itself looks right and matches the
repro in #42243.
Couple of things to look into...
The `cellBarStyles`/`arrowStyles` css`` reformatting around
`TableChart.tsx:1188-1200` isn't part of the page-size fix and isn't mentioned
in the description. Any reason it's riding along in this PR? I'd rather keep
this one scoped to the pagination bug.
Also, the new test wraps its assertions in `if (selectTrigger) { ... }`
(`TableChart.test.tsx`), so if that selector ever goes missing the regression
check just silently no-ops instead of failing. Worth asserting `selectTrigger`
exists before the `waitFor`, otherwise the test can pass without actually
checking anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
