rusackas commented on code in PR #42546:
URL: https://github.com/apache/superset/pull/42546#discussion_r3671582374
##########
superset-frontend/packages/superset-ui-core/src/components/UnsavedChangesModal/index.tsx:
##########
@@ -22,7 +22,7 @@ import type { FC, ReactElement } from 'react';
// Ant Design's default modal zIndex is 1000. Using a higher value ensures
// this dialog always renders above other open modals (e.g. a draggable View
SQL modal).
-const UNSAVED_CHANGES_MODAL_Z_INDEX = 1100;
+const UNSAVED_CHANGES_MODAL_Z_INDEX = 1300;
Review Comment:
Swept the whole frontend for this: `UnsavedChangesModal` is the only place
anywhere that hardcodes a zIndex override on a Modal. Everywhere else either
doesn't need one, or already uses the token correctly (`PopoverDropdown` uses
`theme.zIndexBase`, `SliceHeaderControls` uses `theme.zIndexPopupBase ± 1`).
The other z-index literals in the codebase are unrelated, local stacking
contexts, chart canvases, drag previews, resize handles, nothing competing with
the popup system, so no broader sweep needed.
Also checked every caller, the stories file, and the tests: nobody ever
passes a custom `zIndex` to this component. So the fuller fix isn't defaulting
the constant to `undefined`, it's dropping the whole `zIndex` prop (the type,
the default, and the pass-through) and just letting `<Modal>` render with no
override, same as every other modal in the app.
Happy to just push the cleaner version (or open a fresh PR with it) if
that's easier than digging back in, no worries either way if you'd rather
finish it yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
