rusackas commented on code in PR #42546:
URL: https://github.com/apache/superset/pull/42546#discussion_r3671606295


##########
superset-frontend/packages/superset-ui-core/src/components/UnsavedChangesModal/index.tsx:
##########
@@ -22,7 +22,7 @@ import type { FC, ReactElement } from 'react';
 
 // Ant Design's default modal zIndex is 1000. Using a higher value ensures
 // this dialog always renders above other open modals (e.g. a draggable View 
SQL modal).
-const UNSAVED_CHANGES_MODAL_Z_INDEX = 1100;
+const UNSAVED_CHANGES_MODAL_Z_INDEX = 1300;

Review Comment:
   I'm having an agent look at this ^ a bit more. I would love for your PR to 
"win" here, but I'm curious if we can sweep the codebase and delete ALL the 
z-index complexities to just let AntD do what it does naturally, now that we're 
on V6, so you might see an alternate PR we can assess in parallel. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to