codeant-ai-for-open-source[bot] commented on code in PR #42472:
URL: https://github.com/apache/superset/pull/42472#discussion_r3673759633
##########
scripts/change_detector.py:
##########
@@ -69,6 +72,35 @@
GITHUB_TOKEN = os.environ.get("GITHUB_TOKEN")
+def _is_rate_limited(err: HTTPError) -> bool:
+ """Whether a 403 is GitHub throttling rather than a missing token scope."""
+ headers = getattr(err, "headers", None)
+ if headers is None:
+ return False
+ try:
+ return (
+ headers.get("x-ratelimit-remaining") == "0"
+ or headers.get("retry-after") is not None
+ )
+ except AttributeError:
+ return False
+
+
+def _api_error_detail(err: object) -> str:
+ """The API's own explanation, e.g. ``Resource not accessible by
integration``.
+
+ Without this a 403 is indistinguishable from a rate limit in the CI log.
+ """
+ try:
+ body = err.read().decode("utf-8", "replace") # type:
ignore[attr-defined]
+ except Exception: # noqa: BLE001 # pylint: disable=broad-except
+ return ""
+ try:
+ return json.loads(body).get("message") or body
+ except (ValueError, AttributeError):
+ return body
Review Comment:
**Suggestion:** The API response is printed without a size limit. A large or
HTML error response from GitHub can flood CI logs, so truncate the extracted
message/body to at most 500 characters before returning it. [security]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ GitHub change-detection failures can flood CI logs.
- ⚠️ Oversized diagnostics obscure actionable API error messages.
- ⚠️ CI log storage and rendering incur unnecessary overhead.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3aed116258dd44de9337666ea6183cc6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3aed116258dd44de9337666ea6183cc6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** scripts/change_detector.py
**Line:** 99:101
**Comment:**
*Security: The API response is printed without a size limit. A large or
HTML error response from GitHub can flood CI logs, so truncate the extracted
message/body to at most 500 characters before returning it.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42472&comment_hash=e4d30a94e937a8a5f1a0b0a2ecb50e4aac280f5da1ad1bbbb114ab59370c9120&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42472&comment_hash=e4d30a94e937a8a5f1a0b0a2ecb50e4aac280f5da1ad1bbbb114ab59370c9120&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
