EnxDev commented on code in PR #42472: URL: https://github.com/apache/superset/pull/42472#discussion_r3673762216
########## docs/admin_docs/security/security.mdx: ########## @@ -247,6 +247,42 @@ This feature is particularly useful for: - Granting access to dashboards without exposing the underlying datasets for other uses - Creating dashboard-specific access patterns that don't align with dataset permissions +#### Assigning the creator's groups automatically + +```python +ASSIGN_CREATOR_GROUPS_AS_VIEWERS = True +``` + +With this enabled, a newly created dashboard or chart is shared read-only with every group its +creator belongs to, unless the create payload names viewers explicitly. It applies to every path +that creates an asset: the REST API, `/dashboard/new/`, save-as from Explore, dashboard copy, +the import commands, and the MCP tools. Datasets are unaffected, as they have editors but no +viewers. + +For dashboards, viewer access additionally requires the dashboard to be **published** — the same +rule that governs every dashboard viewer. Until a new dashboard is published its creator's groups +see nothing, and because it now has viewers the dataset-based fallback no longer applies to it +either; group members gain access only once it is published. Charts have no such gate, so a new +chart is visible to the creator's groups immediately. Review Comment: Correct, and thanks; verified against has_promiscuous_chart_access (security/manager.py:4081-4110) and test_raise_for_access_datasource_chart_viewer_no_promiscuous_denies. The viewer grant conveys access to the chart object, but rendering its data still runs the datasource check unless VIEWER_PROMISCUOUS_MODE is on. Reworded the doc: "…the viewer relationship governs access to the chart itself; rendering its data still runs the normal datasource permission check unless VIEWER_PROMISCUOUS_MODE is enabled — a group member without dataset access can open the chart but won't load its data." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
