rusackas opened a new pull request, #42586:
URL: https://github.com/apache/superset/pull/42586
### SUMMARY
Follow-up to #35959. `BUILD_TRANSLATIONS` was documented as "whether to
build the translations into the image," but not that it only does anything when
building from source, extending an already-published tag (the pattern this same
page already documents) can't add translations after the fact, since
non-English files are already stripped out of the published layers by the time
a tag ships. That gap caused real confusion in #35959: a user tried exactly the
"small downstream Dockerfile" pattern with `ARG BUILD_TRANSLATIONS=true` and it
silently did nothing.
Adds a new "Adding translations to a custom image" section documenting the
multi-stage `COPY --from=superset-node` / `COPY
--from=python-translation-compiler` pattern @dawagner worked out in that thread
(verified the stage names and output paths still match the current
`Dockerfile`), and updates the `BUILD_TRANSLATIONS` ARG description to point at
it. Also fixed a stray missing space ("backendthis" → "backend this") while in
there.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, docs only.
### TESTING INSTRUCTIONS
Read-through; `pre-commit run` passes on the changed file. The documented
Dockerfile snippet's stage names (`superset-node`,
`python-translation-compiler`) and paths (`/app/superset/translations`,
`/app/translations_mo`) were checked against the current `Dockerfile` on
`master`, not just copied from the issue comment.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #35959
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
