rusackas commented on code in PR #42586: URL: https://github.com/apache/superset/pull/42586#discussion_r3680299759
########## docs/admin_docs/installation/docker-builds.mdx: ########## @@ -112,12 +112,57 @@ USER superset CMD ["/app/docker/entrypoints/run-server.sh"] ``` +### Adding translations to a custom image + +The pattern above, a small Dockerfile that just extends `FROM apache/superset:...`, can't add +translations after the fact. By the time an official tag is published, its frontend and backend +layers have already had non-English translation files stripped out unless `BUILD_TRANSLATIONS` +was set at build time (see below), and there's no `superset/translations` source tree left in the +final image to compile from. + +To get translations into your own image, you need to build from the full Superset source (a +clone or fork of this repo) rather than extend a published tag. The most efficient way to do this +is to append your customizations as one more stage at the end of the repo's own `Dockerfile`, so +Docker can reuse the cached upstream layers and only rebuild what your stage adds: + +```Dockerfile +# Append this to the end of the repo's Dockerfile +# Keep this tag in sync with the branch/tag of the repo you cloned, so the +# translation files built from source match the keys the runtime expects: +FROM apache/superset:5.0.0 AS my-custom-image +USER root + +# Pull the compiled translation files out of the earlier build stages. These +# only exist mid-build (frontend .json in `superset-node`, backend .mo in +# `python-translation-compiler`) and get stripped from the final `lean`/`dev` +# stages unless BUILD_TRANSLATIONS=true. Review Comment: Good catch, fixed! That bracket glob only matches single-character extensions so `.po` can leak through. Added an explicit `find ... -delete` step to the snippet so the custom image only gets the compiled files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
