codeant-ai-for-open-source[bot] commented on code in PR #42309:
URL: https://github.com/apache/superset/pull/42309#discussion_r3679164463
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb:
##########
@@ -3794,6 +3795,35 @@
"not speed_run and italy_regions.plot(figsize=(10, 7), **plot_styles)"
]
},
+ {
+ "cell_type": "markdown",
+ "metadata": {},
+ "source": [
+ "#### Italy Regions and Autonomous Provinces"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": null,
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "trento_and_bozen = df[(df.admin == 'Italy') &
(df.iso_3166_2.isin(['IT-TN', 'IT-BZ']))][['geometry','iso_3166_2','name']]\n",
+ "\n",
+ "italy_regions_and_autonomous_provinces = pd.concat([italy_regions,
trento_and_bozen])\n",
+ "\n",
+ "italy_regions_and_autonomous_provinces =
italy_regions_and_autonomous_provinces[italy_regions_and_autonomous_provinces['iso_3166_2']
!= 'IT-32']"
Review Comment:
**Suggestion:** The new map removes `IT-32`, but the chart still passes the
selected entity values through unchanged and `CountryMap` matches them by exact
ISO code. Any dataset using the existing regional code `IT-32` will therefore
show Trentino-Alto Adige as uncolored and the new autonomous-province regions
will have no metric or filter match. Add an explicit data-code
migration/compatibility path or clearly enforce that this map requires `IT-TN`
and `IT-BZ` values. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Existing regional `IT-32` datasets render Trentino-Alto Adige uncolored.
- ⚠️ New-map cross-filters require `IT-TN` or `IT-BZ` values.
- ⚠️ Users receive no configuration warning for incompatible granularity.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7f8a49d513524593bb151b45aa191c69&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7f8a49d513524593bb151b45aa191c69&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb
**Line:** 3815:3815
**Comment:**
*Api Mismatch: The new map removes `IT-32`, but the chart still passes
the selected entity values through unchanged and `CountryMap` matches them by
exact ISO code. Any dataset using the existing regional code `IT-32` will
therefore show Trentino-Alto Adige as uncolored and the new autonomous-province
regions will have no metric or filter match. Add an explicit data-code
migration/compatibility path or clearly enforce that this map requires `IT-TN`
and `IT-BZ` values.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42309&comment_hash=b78d9fabb472d6320f7eb696762aa430493baad3ee70501c174aad854ba2fe2e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42309&comment_hash=b78d9fabb472d6320f7eb696762aa430493baad3ee70501c174aad854ba2fe2e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
