rusackas commented on PR #42539: URL: https://github.com/apache/superset/pull/42539#issuecomment-5127247030
@mikebridge this looks like a solid fix, threading `datasourceType` through instead of resolving by id alone. One thing before I'd merge: Bito's flagging that the `semanticViewDimensionsToColumns` test in `utils.test.ts` doesn't assert `type_generic`, so a regression in `mapSemanticTypeToGenericDataType` would pass silently. Worth adding. Also a handful of other bot threads are still open (the `as unknown as Dataset`/`Metric[]` casts, the cross-layer import into `datasets.ts`), if you don't mind giving those a look too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
