rusackas commented on code in PR #42539: URL: https://github.com/apache/superset/pull/42539#discussion_r3706254725
########## superset-frontend/src/dashboard/components/nativeFilters/useDisplayControlDatasource.ts: ########## @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useEffect, useRef, useState } from 'react'; +import { DatasourceType } from '@superset-ui/core'; +import { cachedSupersetGet } from 'src/utils/cachedSupersetGet'; +import { + fetchSemanticViewStructure, + semanticViewDimensionsToColumns, +} from './FiltersConfigModal/FiltersConfigForm/utils'; + +/** The column fields display controls read to build their options. */ +export interface DisplayControlColumn { + column_name?: string; + name?: string; + verbose_name?: string | null; + filterable?: boolean; +} + +export interface DisplayControlDatasource { + /** The datasource's display name (dataset table_name / semantic view name). */ + name: string | undefined; + columns: DisplayControlColumn[]; + loading: boolean; + error: Error | undefined; +} + +/** + * The single, type-aware datasource resolution point for dashboard display + * controls (Dynamic group by today; siblings adopt this hook as they gain + * loaders). + * + * Semantic views and regular datasets have independent numeric-id + * sequences, so a binding must be resolved by BOTH id and datasourceType — + * an id-only lookup silently reads whatever regular dataset shares the + * view's number (sc-111089). The default branch preserves the legacy + * display-control request (`GET /api/v1/dataset/<id>`, full resource, no + * projection) byte-for-byte; changing that shape is a deliberate, + * separately-tested decision, not a drive-by. + * + * Responses are guarded by a monotonic request id: on a same-id type flip + * a slow response for the previous binding is discarded rather than + * overwriting the newer one — reintroducing the wrong-object bug through + * a race would otherwise be possible. + */ +export function useDisplayControlDatasource( + datasetId: number | string | undefined | null, + datasourceType?: DatasourceType, +): DisplayControlDatasource { + const [name, setName] = useState<string | undefined>(); + const [columns, setColumns] = useState<DisplayControlColumn[]>([]); + const [loading, setLoading] = useState(false); + const [error, setError] = useState<Error | undefined>(); + const requestIdRef = useRef(0); + + useEffect(() => { + // Invalidate any in-flight request on every binding change (and on + // unmount, via the cleanup below). + requestIdRef.current += 1; + const requestId = requestIdRef.current; + + if (datasetId === undefined || datasetId === null || datasetId === '') { + // Unbound control: inert, nothing to fetch. + setName(undefined); + setColumns([]); + setLoading(false); + setError(undefined); + return undefined; + } + + setLoading(true); + setError(undefined); + + const load = async (): Promise<{ + name: string | undefined; + columns: DisplayControlColumn[]; + }> => { + if (datasourceType === DatasourceType.SemanticView) { + const structure = await fetchSemanticViewStructure(datasetId); + return { + name: structure.name, + columns: semanticViewDimensionsToColumns(structure.dimensions), + }; + } + const { json } = await cachedSupersetGet({ + endpoint: `/api/v1/dataset/${datasetId}`, + }); Review Comment: I don't think this applies here. `datasetId` in this path is always a plain numeric id (`NativeFilterTarget.datasetId: number`), never the `<id>__<type>` composite string. That composite parsing lives in `getDatasourceTypeFromId`, which operates on `formData.datasource` strings, a different code path entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
