aminghadersohi opened a new pull request, #42619:
URL: https://github.com/apache/superset/pull/42619

   ### SUMMARY
   
   Metric expressions that do not match the built-in aggregation pattern are a 
supported fallback: `get_metric_type_from_column` returns an empty inferred 
type for them. Logging this case at warning level creates repeated noise when 
dataframe types are inferred across query result columns.
   
   This changes the existing message from warning to debug level while 
preserving its text and arguments. The unit test is updated to verify the debug 
call.
   
   ### TESTING INSTRUCTIONS
   
   Run:
   
   ```bash
   pytest -q tests/unit_tests/utils/map_type_tests.py
   pre-commit run --files superset/utils/core.py 
tests/unit_tests/utils/map_type_tests.py
   ```
   
   Verified locally: 11 tests passed, and all pre-commit hooks applicable to 
the changed files passed.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   #### Blast radius
   
   Backend logging only. There are no behavior, API, database, security, or UI 
changes.
   
   #### Risk and rollback
   
   Low risk: unexpected metric expressions remain observable at debug level. 
Roll back by reverting the commit.
   
   #### Review guidance
   
   Review the log-level change in `superset/utils/core.py` and its matching 
unit-test expectation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to