aminghadersohi commented on code in PR #42619:
URL: https://github.com/apache/superset/pull/42619#discussion_r3691506156
##########
tests/unit_tests/utils/map_type_tests.py:
##########
@@ -42,9 +42,9 @@ def test_column_with_invalid_operation():
metric = SqlMetric(metric_name="my_column",
expression="INVALID(my_column)")
datasource = MagicMock(metrics=[metric])
column = "my_column"
- with patch("superset.utils.core.logger.warning") as mock_warning:
+ with patch("superset.utils.core.logger.debug") as mock_debug:
assert (get_metric_type_from_column(column, datasource)) == ""
- mock_warning.assert_called_once()
+ mock_debug.assert_called_once()
Review Comment:
Addressed in e84f2e09d4a244b5b4289f876d2ffbcf624957bf. The test now asserts
the exact debug message and invalid metric expression arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
