sadpandajoe commented on code in PR #42620:
URL: https://github.com/apache/superset/pull/42620#discussion_r3685939155
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -424,7 +432,7 @@ export const SaveDatasetModal = ({
const filterAutocompleteOption = (
inputValue: string,
option: DatasetOverwriteOption,
- ) => option.value.toLowerCase().includes(inputValue.toLowerCase());
+ ) => option.label.toLowerCase().includes(inputValue.toLowerCase());
Review Comment:
When the editable dataset list spans more than one page, typing the new
schema prefix still sends `prod.` to the API as a `table_name` filter, so the
async response replaces the options with an empty list even when
`prod.task_instance` exists. Could the server query search schema/qualified
labels too, or otherwise keep schema filtering client-side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
