codeant-ai-for-open-source[bot] commented on code in PR #42620:
URL: https://github.com/apache/superset/pull/42620#discussion_r3691143048
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -342,9 +385,19 @@ export const SaveDatasetModal = ({
endpoint: `/api/v1/dataset/?q=${queryParams}`,
Review Comment:
**Suggestion:** The loader ignores the `page` and `pageSize` arguments
required by `AsyncSelect` and never sends pagination parameters to the dataset
API. When more than one page matches the table-name filter, subsequent scroll
requests retrieve the same first page, so editable datasets beyond the first
page cannot be selected. Accept the pagination arguments and include the
corresponding page and page-size query parameters. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Large overwrite lists cannot expose later datasets.
- ❌ SQL Lab users cannot select some editable datasets.
- ⚠️ AsyncSelect pagination repeatedly fetches page one.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ff1c4c69668e49698f9d07e55d35ce6d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ff1c4c69668e49698f9d07e55d35ce6d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
**Line:** 367:385
**Comment:**
*Api Mismatch: The loader ignores the `page` and `pageSize` arguments
required by `AsyncSelect` and never sends pagination parameters to the dataset
API. When more than one page matches the table-name filter, subsequent scroll
requests retrieve the same first page, so editable datasets beyond the first
page cannot be selected. Accept the pagination arguments and include the
corresponding page and page-size query parameters.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42620&comment_hash=d7082df8766dff70aba5be331346fc4ea9aee5b5fcdd0baae22c4274cd1a7829&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42620&comment_hash=d7082df8766dff70aba5be331346fc4ea9aee5b5fcdd0baae22c4274cd1a7829&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
