bito-code-review[bot] commented on code in PR #42483:
URL: https://github.com/apache/superset/pull/42483#discussion_r3690202869
##########
superset-frontend/src/explore/components/DatasourcePanel/types.ts:
##########
@@ -27,6 +27,18 @@ export interface DatasourcePanelDndItem {
type: DndItemType;
}
+/**
+ * Payload for dragging a whole folder out of the DatasourcePanel. `items` are
+ * the folder's columns/metrics (recursively including subfolders) already
+ * shaped as individual DnD items so drop targets can reuse their per-item
+ * `canDrop`/`onDrop` logic.
+ */
+export interface FolderDndItem {
+ type: DndItemType.Folder;
+ name: string;
+ items: DatasourcePanelDndItem[];
+}
Review Comment:
<!-- Bito Reply -->
The suggestion to remove the `FolderDndItem` interface is appropriate if it
is indeed unused in the codebase. Since the interface is exported but not
referenced, and its structure does not align with the actual drag data object
used in the application, removing it helps maintain a cleaner codebase and
prevents confusion for future developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
