mikebridge commented on PR #41550: URL: https://github.com/apache/superset/pull/41550#issuecomment-5143045971
**Addendum: independent Codex capstone pass, reconciled.** A second capstone review was run via OpenAI Codex over the same scope; it resolved the branch's PR against the fork remote and posted there — [mikebridge#6 (comment)](https://github.com/mikebridge/superset/pull/6#issuecomment-5142864861) — but the content applies to this PR verbatim. Most of its findings matched the 10-lens capstone above (already fixed or triaged). Four were live and are fixed in `45eed1366e`, each with a verified control: 1. **Its one HIGH — reconciliation attributed success it did not witness.** A stale pending audit row whose entity is gone proves *some* purge committed, not that it was this attempt. Such rows now finalize as a distinct `reconciled_absent` status (no `confirmed_on`), so the compliance record claims exactly what is known. 2. **The purge route's outer exception path still leaked driver text** — the earlier curation covered the cascade's IntegrityError, not the route-level `except SQLAlchemyError`. The client now gets a stable sentence; the cause goes to the log. The pre-existing 422 test *asserted the leak* and now pins the curated contract instead. 3. **Blocked/failed audit rows kept the intended-removal count** (new — no lens in the first panel caught it): the write-ahead's pre-purge count survived on rows whose cleanup rolled back, asserting removals that never happened. Zeroed on non-success; kept deliberately on `reconciled_absent`, where the same transaction removed them. 4. **Archive row actions re-enabled before the refetch settled** ⚑2 — both handlers now await `refreshData()` so the in-flight guard outlives the stale row. Remaining Codex items are the same follow-up set as the capstone's (purge-policy registration for future adopters, reconcile lease/heartbeat, route dedup, typed-Column style). _Generated by Claude (AI) on behalf of @mikebridge._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
