mikebridge commented on PR #41550: URL: https://github.com/apache/superset/pull/41550#issuecomment-5144273869
@kgabryje thanks for the review — every item is addressed as of `0ce35d8224`, with per-thread replies inline. The short version: - **1 (status column)**: was already fixed at `44764616b6` — the constant is `target_absent` now; your review ran one sha behind. - **2 (sort-axis leak)**: fixed — the type switch clears `sortColumn`/`sortOrder`/`pageIndex`, which also closes the pageIndex carry-over; regression test is the shape you suggested and fails pre-fix. - **3 (Playwright dead coverage)**: fixed — dedicated flag-on "Soft-delete Tests" step in `superset-e2e.yml`, per-step server isolation mirroring the Embedded step. - **4 (purge friction)**: took your recommendation — type-to-confirm restored on permanent delete; unit + e2e updated. - **5 (timedelta overflow)**: fixed with an integration test that 500s pre-fix. - **6 (msgid)**: acknowledged in the PR description. - **7 (unreachable empty state)**: resolved toward "403 is the behaviour" — description and comments now say so; the branch stays as defence-in-depth + the type guard TS requires. Also folded in today's codeant round: flag decorators on the nine archive-listing tests (the chart suite had the same gap uncalled), `extractIdFromResponse` in the new specs, and two declines with reasons (raw `str(ex)` must not reach `blocked_reason`; the recency filter deliberately does not imply the visibility bypass, which carries audience scoping). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
