mikebridge commented on PR #41550: URL: https://github.com/apache/superset/pull/41550#issuecomment-5144556188
Follow-up `b20ca29481` on the CI run at `0ce35d8224`: the new flag-on step ran the recently-archived specs **for the first time ever** (they had always skipped), and first execution surfaced two latent bugs in the specs themselves — an unscoped Archive-button locator (strict-mode violation: with the flag on, every list row's delete action is also named Archive) and a bare-path URL assertion that only passed by racing ListView's immediate query-param write. Both fixed with the failure reproduced locally against a flag-on stack first. The `test-mysql` failure was a pre-existing coin-flip dialect flake the same run happened to surface: MySQL DATETIME(0) rounds fractional seconds up, so an exact now()-10d stamp can humanize to '9 days ago'; the assertion now sits an hour off the day boundary. Net effect of this round: 7 of the 8 archive E2E specs now execute and pass in CI (the eighth passes on CI retry under worker load) — which is rather the point of review item 3. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
