bito-code-review[bot] commented on PR #42644:
URL: https://github.com/apache/superset/pull/42644#issuecomment-5144813828
<!-- Bito Reply -->
The logging changes in this pull request are designed to avoid logging
sensitive information by using structured logging that captures only metadata,
such as `database_id`, `engine`, and `error_type`. The code explicitly avoids
logging the raw exception object or user-specific data that might contain
credentials. These changes are appropriate and follow security best practices
for structured logging.
**superset/commands/database/oauth2.py**
```
except Exception as ex:
logger.error(
"OAuth2 token exchange failed: database_id=%s engine=%s "
"error_type=%s",
self._state["database_id"],
self._database.backend,
type(ex).__name__,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
