codeant-ai-for-open-source[bot] commented on code in PR #42644:
URL: https://github.com/apache/superset/pull/42644#discussion_r3694151627
##########
superset/databases/api.py:
##########
@@ -1454,10 +1454,11 @@ def validate_sql(self, pk: int) -> FlaskResponse:
return self.response_404()
@expose("/oauth2/", methods=["GET"])
+ @statsd_metrics
Review Comment:
**Suggestion:** The newly added `statsd_metrics` wrapper emits the failure
counter from its exception handler without protecting `self.incr_stats(...)`.
If the configured StatsD client fails while recording an OAuth2 error, that
secondary exception replaces the original callback failure and can change the
response and traceback presented to the client. Make metric emission
best-effort so observability failures cannot mask the OAuth2 exception. [error
handling]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ OAuth2 failure responses can expose a StatsD error instead.
- โ ๏ธ Original token-exchange diagnostics can be lost.
- โ ๏ธ Callback error handling depends on StatsD availability.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=25564dc5720148edb7804be477f2b52b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=25564dc5720148edb7804be477f2b52b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/databases/api.py
**Line:** 1457:1457
**Comment:**
*Error Handling: The newly added `statsd_metrics` wrapper emits the
failure counter from its exception handler without protecting
`self.incr_stats(...)`. If the configured StatsD client fails while recording
an OAuth2 error, that secondary exception replaces the original callback
failure and can change the response and traceback presented to the client. Make
metric emission best-effort so observability failures cannot mask the OAuth2
exception.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42644&comment_hash=6f35543f0d60d7497c8157862a250555c555cdb42fdcef8405ac210450bdf506&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42644&comment_hash=6f35543f0d60d7497c8157862a250555c555cdb42fdcef8405ac210450bdf506&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
