bito-code-review[bot] commented on code in PR #42712:
URL: https://github.com/apache/superset/pull/42712#discussion_r3704937477
##########
superset-frontend/plugins/preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx:
##########
@@ -283,8 +283,6 @@ export const fillColorPicker: CustomControlItem = {
type: 'ColorPickerControl',
default: PRIMARY_COLOR,
renderTrigger: true,
- visibility: ({ controls }) =>
- isColorSchemeTypeVisible(controls, COLOR_SCHEME_TYPES.fixed_color),
},
};
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Control visibility logic removed</b></div>
<div id="fix">
Removing the `visibility` constraint on `fillColorPicker` makes it
unconditionally visible. Previously it only appeared when `color_scheme_type`
was set to `fixed_color`. Now users will see this control even when using
categorical/linear color schemes where it has no effect. Please confirm this
visibility change is intentional.
</div>
</div>
<small><i>Code Review Run #ffd628</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
