sadpandajoe commented on code in PR #42712:
URL: https://github.com/apache/superset/pull/42712#discussion_r3740958508
##########
superset-frontend/plugins/preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx:
##########
@@ -284,6 +284,7 @@ export const fillColorPicker: CustomControlItem = {
default: PRIMARY_COLOR,
renderTrigger: true,
visibility: ({ controls }) =>
+ !controls.color_scheme_type ||
Review Comment:
This fixes a user-visible regression through an untested two-branch
predicate, so the GeoJSON picker can disappear again or the Polygon picker can
show for non-fixed schemes without a relevant Jest failure. Could we add a
focused `fillColorPicker.config.visibility` test covering an absent
`color_scheme_type`, `fixed_color`, and the non-fixed values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
