rusackas opened a new pull request, #42715:
URL: https://github.com/apache/superset/pull/42715

   ### SUMMARY
   
   The gantt-chart timing from a recent E2E run ([run 
30826232203](https://github.com/apache/superset/actions/runs/30826232203?pr=42713))
 shows the two-way Cypress shard split isn't buying real parallelism anymore. 
Both shards pay ~8-9 minutes of identical setup (checkout, postgres, test-data 
import, npm install, JS build, cypress install) before a single spec runs, and 
the actual "Run Cypress" step itself only took 2m15s on one shard and 35s on 
the other. Splitting across two runners roughly doubles billed runner-minutes 
for a suite whose combined actual test execution is well under 3 minutes, since 
the setup cost is fully duplicated per shard instead of amortized.
   
   This collapses `cypress-matrix` to a single runner (drops the `parallel_id` 
matrix dimension and its `exclude` rule). `.asf.yaml` only requires the 
aggregate `cypress-matrix-required` bridge job, not the per-shard job names, so 
this doesn't affect required-check enforcement.
   
   Also cleans up the parallelization plumbing that's now dead weight at a 
single shard: `scripts/cypress_run.py` drops the 
`--parallelism`/`--parallelism-id` round-robin distribution logic (confirmed 
via repo-wide grep this script has no other caller), and `bashlib.sh`'s 
`cypress-run-all()` no longer needs to forward `PARALLEL_ID`/`PARALLELISM` into 
it.
   
   ### TESTING INSTRUCTIONS
   
   - CI on this PR will run the collapsed single-runner `cypress-matrix` job; 
compare its wall-clock time against a recent 2-shard run to confirm no 
regression.
   - `python3 scripts/cypress_run.py --dry-run --retries 1` runs standalone 
without `--parallelism`/`--parallelism-id` and discovers/dry-runs every spec 
directly.
   - `pre-commit run --files scripts/cypress_run.py 
.github/workflows/bashlib.sh .github/workflows/superset-e2e.yml` passes clean, 
including the `zizmor` GHA security audit.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [x] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to