sadpandajoe commented on code in PR #42498:
URL: https://github.com/apache/superset/pull/42498#discussion_r3723792932


##########
.github/workflows/superset-docs-deploy.yml:
##########
@@ -76,7 +76,10 @@ jobs:
           distribution: "zulu"
           java-version: "21"
       - name: Install Graphviz
-        run: sudo apt-get install -y graphviz
+        uses: 
awalsh128/cache-apt-pkgs-action@553a35bb8ebd9fcabcb1c9451aa4c98e1b4ca8a9 # 
v1.6.3
+        with:
+          packages: graphviz
+          version: 1.0

Review Comment:
   On a cache hit this action restores only dpkg-listed files and skips 
`libgvc6`'s post-install script, so Graphviz's generated `config6a` is missing 
and the PlantUML ERD render can fail after the first cached run. Could we 
enable `execute_install_scripts` here (and ideally smoke-check `dot`), or leave 
Graphviz on `apt-get`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to