bito-code-review[bot] commented on PR #42813: URL: https://github.com/apache/superset/pull/42813#issuecomment-5197364336
<!-- Bito Reply --> The flagged issue regarding the abrupt transition when switching from an active to an inactive tile is correct. When the `transition` property is set to `none` based on the active state, it prevents the browser from animating the width change, causing an abrupt layout shift. To resolve this, you should ensure the `transition` property remains enabled or is applied independently of the active state. For example, you can move the `transition` property outside of the conditional block that toggles based on the active state, or ensure it is always present on the element. Since the file `superset-frontend/src/explore/components/controls/VizTypeControl/VizTile.tsx` is not present in the provided PR diff, I cannot implement the fix directly. Please verify the file path and ensure the relevant code is included in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
