codeant-ai-for-open-source[bot] commented on code in PR #42813:
URL: https://github.com/apache/superset/pull/42813#discussion_r3724040341
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx:
##########
@@ -46,32 +46,36 @@ const ButtonsContainer = styled.div<{ isVertical: boolean
}>`
${({ theme, isVertical }) => css`
display: flex;
- ${isVertical
- ? css`
- flex-direction: column;
- align-items: center;
- position: sticky;
- z-index: 100;
- bottom: 0;
- padding: ${theme.sizeUnit * 4}px;
- padding-top: ${theme.sizeUnit * 6}px;
- background: linear-gradient(
- ${tinycolor(theme.colorBgLayout).setAlpha(0).toRgbString()},
- ${theme.colorBgContainer} 20%
- );
- `
- : css`
- align-items: center;
- margin-left: auto;
- `}
+ ${
+ isVertical
+ ? css`
+ flex-direction: column;
+ align-items: center;
+ position: sticky;
+ z-index: 100;
+ bottom: 0;
Review Comment:
**Suggestion:** The vertical filter bar's scrollable element is the sibling
filter-content pane, not this container, so `position: sticky` with `bottom: 0`
cannot keep the actions pinned while that pane scrolls. The actions remain
after the scrollable pane and can move out of view, while the existing content
padding still reserves space for the previous absolute-positioned layout. Place
the actions inside the scroll container or position them relative to the
vertical bar with the corresponding height/layout rules. [css layout issue]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Vertical filter actions can remain below the visible filter pane.
- ⚠️ Apply and Clear all become difficult to access with many filters.
- ⚠️ Vertical native-filter layout retains obsolete bottom-space reservation.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f92631c5da0141718c2de4df53b8a24d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f92631c5da0141718c2de4df53b8a24d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
**Line:** 54:56
**Comment:**
*Css Layout Issue: The vertical filter bar's scrollable element is the
sibling filter-content pane, not this container, so `position: sticky` with
`bottom: 0` cannot keep the actions pinned while that pane scrolls. The actions
remain after the scrollable pane and can move out of view, while the existing
content padding still reserves space for the previous absolute-positioned
layout. Place the actions inside the scroll container or position them relative
to the vertical bar with the corresponding height/layout rules.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42813&comment_hash=596c1c041b46d52143f35bed60f6d8935c98f9af45d61510660c3b6f02cb6f84&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42813&comment_hash=596c1c041b46d52143f35bed60f6d8935c98f9af45d61510660c3b6f02cb6f84&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
