bito-code-review[bot] commented on PR #42734:
URL: https://github.com/apache/superset/pull/42734#issuecomment-5202199862
<!-- Bito Reply -->
The test case provided in the PR specifically targets the `transformProps`
function to ensure it correctly processes multiple rows of GeoJSON data,
addressing the issue where only the first row was being rendered. While this
test verifies that `transformProps` correctly aggregates features from the
query data, it does not exercise the subsequent rendering pipeline (e.g.,
`recurseGeoJson` or the `GeoJsonLayer` component itself).
If the underlying issue involves data being dropped at the consumer/render
boundary rather than in the transformation logic, this test will pass while the
production failure persists. It is advisable to keep the `Closes` reference if
the transformation logic was indeed the root cause, but if there is uncertainty
about the boundary, adding an integration test or a component-level test that
renders the layer would provide more robust verification.
**superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/transformProps.test.ts**
```
const result = transformProps(mockChartProps as ChartProps);
const features = result.payload.data.features as Array<{
geometry: { coordinates: number[] };
}>;
expect(features).toHaveLength(3);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
