sadpandajoe commented on code in PR #42734: URL: https://github.com/apache/superset/pull/42734#discussion_r3727121841
########## superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/transformProps.test.ts: ########## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { ChartProps, DatasourceType } from '@superset-ui/core'; +import transformProps from './transformProps'; + +// Regression for https://github.com/apache/superset/issues/34748: reporters +// on 5.0.0/6.0.0 found that only a single row's GeoJSON Feature ever +// rendered on the map, no matter how many rows the query returned (setting +// the row limit to 1 made no visible difference). +test('transformProps builds a feature for every row, not just the first', () => { Review Comment: This can close #34748 while leaving the reported failure untested: the legacy backend already emitted one feature per row, and this assertion stops before `recurseGeoJson`/`GeoJsonLayer`, where payloads can still be dropped. Could this exercise the consumer/render boundary, or avoid `Closes` until the actual failing boundary is identified? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
