rusackas commented on PR #40635:
URL: https://github.com/apache/superset/pull/40635#issuecomment-5227451583
Since this ended up as a semantic merge rather than a plain rebase (master's
catalog moved a lot since June, five other French PRs landed independently),
here's exactly what got kept vs. overridden, in case anything below is worth a
second opinion or a follow-up tweak.
**Overridden in favor of `master`'s version** (anglicisms like
`mail`/`courriel`, terminology drift from this catalog's own dominant
convention, or grammar/meaning regressions found on a full pass):
| `msgid` | Why `master`'s version won |
|---|---|
| `Tag description` *(this one went the other way — your `étiquette` won,
matches the catalog's dominant term 74x vs `balise` 20x)* | — |
| `Delete/Edit/Set up/Schedule an email report`, `Share chart/permalink by
email`, `Image (PNG) embedded in email`, `Email reports active`, and 3 similar
| `mail` anglicism vs. the catalog's established `courriel` |
| `%s metric`, `%s out of %s column/metric/selected`, `Whether to display
the metric name` | `métrique`/`parmi` drift from the dominant `mesure`/`sur`
(104 vs 20, counted) |
| `%s imported`, `User`, `User query`, `Select a %s`, and ~15 more
`user`-related strings | dropped this catalog's `utilisateur·rice`
inclusive-language convention |
| `Deleted %(num)d rules` | broke singular/plural agreement |
| `Deleted %(num)d semantic view`/`theme` | stray "Modèle" prefix not in the
source string |
| `Please reach out to the Chart Editor for assistance.` | "Editor"
mistranslated as "owner" |
| `There was an issue cancelling the task: %s` | "cancelling" mistranslated
as "deleting" |
| `An error occurred while fetching created by values: %s` | mismatched
content ("schéma" doesn't match "created by") |
| `nativeFilters[...] does not exist on the dashboard` | subject/verb number
agreement |
| `nativeFilters[...] must be a non-empty string` | changed "empty" to
"null" — different validation concept |
| `the Handlebars chart documentation`, `The unit for label size`, `Dynamic
Section Label` | anglicisms (`chart`, `label`) vs. established
`graphique`/`étiquette` |
| `e.g., CI/CD Pipeline, Analytics Script` | left partially untranslated |
| `Username is required` | `pseudo` vs. this catalog's `nom d'utilisateur`
elsewhere |
| 4 long help-text entries
(formula/periodicity/WHERE-clause/dashboard-colors strings) | a find-replace
pass had flattened French guillemets (`« »`) to straight quotes and dropped
clauses along the way |
**Mechanical only, content kept**: ~90 entries where your translation was
correct but the same guillemet-flattening had happened — restored `« »`, kept
your wording.
**Your branch actually fixed real bugs already on `master`**, worth knowing
since they're easy to miss: `master` had the min/max metric config strings
swapped, plus a few stranded/copy-pasted entries (`Validating...` was showing
"Chargement...", the configuration-schema error was showing "noms de
fonctions", the user-registration-deletion error was showing "suppression des
règles"). Your branch had all of these right and they're in now.
Happy to hand over the full diff or reasoning on any specific line if
something above looks off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
