jethac opened a new issue, #42980:
URL: https://github.com/apache/superset/issues/42980
### Bug description
`superset/db_engine_specs/lint_metadata.py` exists to verify per-spec
metadata completeness. Running it against `master` today:
```
$ python superset/db_engine_specs/lint_metadata.py --json
{"summary": {"total": 80, "with_metadata": 68, "all_required": 68,
"average_score": 73.7}}
```
Twelve specs report `has_metadata: false`:
| module | engine |
| --- | --- |
| `aurora` | Aurora MySQL |
| `aurora` | Aurora MySQL (Data API) |
| `aurora` | Aurora PostgreSQL |
| `aurora` | Aurora PostgreSQL (Data API) |
| `kusto` | Azure Data Explorer (KQL) |
| `clickhouse` | ClickHouse (sqlalchemy) |
| `databricks` | Databricks (legacy) |
| `databricks` | Databricks Interactive Cluster |
| `databricks` | Databricks SQL Endpoint |
| `ibmi` | IBM Db2 for i |
| `odps` | ODPS (MaxCompute) |
| `elasticsearch` | OpenSearch (OpenDistro) |
The metadata drives what users see when picking a database, so a spec with
none is one a user gets less help connecting to.
### Why this is a tractable target
The verification tool already exists, so each change is objectively
checkable — a reviewer runs the linter rather than adjudicating taste. It
parallelises at one spec per change, each small enough to review quickly.
### Open question worth settling first
Several of these are abstract base classes (`ClickHouseBaseEngineSpec`,
`DatabricksBaseEngineSpec`, `PrestoBaseEngineSpec`, `DatabendBaseEngineSpec`).
It is not obvious whether `lint_metadata.py` should exempt base classes or
whether they should carry metadata like any other spec. Worth deciding before
filling anything in — and if exempting, encoding the exemption in the linter
rather than in a comment.
### Acceptance
- `lint_metadata.py --strict` passes for each spec touched.
- Metadata reflects each engine's actual capabilities, verified against its
driver documentation rather than copied from a neighbouring spec.
Verified against `master` at `3539c41dab`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
