Abdulrehman-PIAIC80387 commented on issue #42980: URL: https://github.com/apache/superset/issues/42980#issuecomment-5312859307
Sending PR #43239 for the ODPS half of this. Ran `lint_metadata.py --json` on current master (still 12 incomplete) and walked each entry — 11 of the 12 explicitly point their docs at another class in the same driver family (Aurora → MySQL/Postgres compatible_databases, KustoKql → KustoSql drivers list, OpenDistro → ElasticSearch, all Databricks legacy → DatabricksPythonConnector, IBMi → Db2, ClickHouse-sqlalchemy → sibling in same file). ODPS is the only leaf where no parent-consolidation exists, so this PR adds real metadata just for it. Verified locally the counts flip 68 → 69 for both `with_metadata` and `all_required` after the change. For the broader design question you raised (whether the linter should exempt those 11 consolidated leaves), I laid out three follow-up options in the PR body — the recommended one is F1: teach the linter to detect the "Documentation ... consolidated in X" docstring pattern and mark those as `consolidated` rather than `false`. Happy to open the follow-up in whichever shape maintainers prefer. CC @rusackas per your ping on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
