rusackas commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-5243883959
Thanks for the rebase, @jayvenn21, but it's conflicting with `master` again. Also, the open question from @dpgaspar about doing this as an upstream FAB config flag (like `FAB_ADD_SECURITY_VIEWS`) instead of monkeypatching `add_view_no_menu` here never got resolved. And @msyavuz's question above about whether admins lose the ability to reset another user's password is still unanswered. Would want both closed out before this can land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
