rusackas commented on PR #42361:
URL: https://github.com/apache/superset/pull/42361#issuecomment-5244802379
Thanks for laying out the case, @Llucs.
One thing before this can go in though. `unit-tests-required` is failing for
real, not flaky. `tests/unit_tests/sql_lab_test.py:87` and `:113` still do
`mocker.patch("backoff._sync.time.sleep")`, and since `backoff` is gone from
requirements now that's a `ModuleNotFoundError`. Looks like that file got
missed in the sweep, only `slack_tests.py` got the rename treatment. Once
that's fixed I'm good to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
