rusackas commented on PR #42705: URL: https://github.com/apache/superset/pull/42705#issuecomment-5244815006
Nice fix for the impersonation no-op on local DuckDB. Codeant's thread on duckdb.py:387 is still open though, and I think it's accurate. `impersonate_user` never clears `url.username`, so a MotherDuck connection configured with one (say, via a raw SQLAlchemy URI instead of the parameters form) would still hit the same connect() kwarg rejection this PR is meant to avoid. Should just be `url = url.set(username=None)` before returning, want to add that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
